Commit 5299c569 authored by Martino Bertoni's avatar Martino Bertoni 🌋
Browse files

embeddings are coherent between reference and full in sign2

parent f84f8120
Pipeline #2491 failed with stages
in 65 minutes and 39 seconds
...@@ -189,15 +189,21 @@ class sign2(BaseSignature, DataSignature): ...@@ -189,15 +189,21 @@ class sign2(BaseSignature, DataSignature):
nearest_neighbor_pred = sign2.predict_nearest_neighbor( nearest_neighbor_pred = sign2.predict_nearest_neighbor(
self.model_path, traintest_file) self.model_path, traintest_file)
extra_preditors['NearestNeighbor'] = nearest_neighbor_pred extra_preditors['NearestNeighbor'] = nearest_neighbor_pred
ada.save_performances(adanet_path, sign2_plot, extra_preditors) ada.save_performances(adanet_path, sign2_plot,
self.__log.debug('model saved to %s' % adanet_path) self.__log.debug('model saved to %s' % adanet_path)
self.update_status("Generating `full` molset") self.update_status("Generating `full` molset")
cc_tmp = self.get_cc() cc_tmp = self.get_cc()
sign1_full = cc_tmp.get_signature('sign1', 'full', self.dataset) sign1_full = cc_tmp.get_signature('sign1', 'full', self.dataset)
sign2_full = cc_tmp.get_signature('sign2', 'full', self.dataset) sign2_full = cc_tmp.get_signature('sign2', 'full', self.dataset)
# we want agreement between reference and full
# so we overwrite the original embeddings using the predictor
sign1_ref = cc_tmp.get_signature('sign1', 'reference', self.dataset)
sign2_ref = cc_tmp.get_signature('sign2', 'reference', self.dataset)
if oos_predictor: if oos_predictor:
self.predict(sign1_full, sign2_full.data_path) self.predict(sign1_full, sign2_full.data_path)
self.predict(sign1_ref, sign2_ref.data_path)
else: else:
# finalize signature # finalize signature
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment